[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: golang-github-russellhaering-goxmldsig version 0.0~git20180430.7acd5e4



Hi Christian,

On 05/01/20 7:01 am, Christian Barcenas wrote:

> I have updated golang-github-russellhaering-goxmldsig and am looking
> for a sponsor to upload it to the Archive.

There are a couple of things that needs fixing..

1. changelog-should-mention-nmu: You should mention "Team upload" in
d/ch (on the top) :)

2. extended-description-is-probably-too-short: It'd be nice if you could
look at the homepage of the upstream and add a bit of description more.

3. out-of-date-standards-version 4.1.1 (released 2017-09-27) (current is
4.4.1).

4. golang-github-russellhaering-goxmldsig source:
package-uses-old-debhelper-compat-version 10.

5. rules-requires-root-missing. Lintian states, "Please specify (eg.)
Rules-Requires-Root: no in the debian/control source stanza, but
packagers should verify using diffoscope(1) that the binaries built with
this field present are identical."

6. upstream-metadata-file-is-missing: Please add d/upstream/metadata.

7. debian/copyright:19 points to a URL that could be be changed to HTTPS.

You could run "cme fix dpkg" to fix most of the above things.
Check with running "lintian" and "duck" too :)

Once done, let me know, I'll be happy to sponsor the upload and push the
changes to the salsa repository.


Best,
Utkarsh

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: