[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Need review and upload: azure-sdk-for-go




On 11/20/19 8:54 AM, Dmitry Smirnov wrote:
I had a quick look and found that even latest release of the latter  (v.
13.3.0 released in October) does not provide "github.com/Azure/go-autorest/
tracing" so we probably need to step back few versions of "azure-sdk-for-
go"...


I think you're mistaken here, the v12 from Apr 2018 provides tracing: https://github.com/Azure/go-autorest/tree/v12.0.0. And this is this version that is used in Azure/azure-sdk-for-go, so it seems reasonable to try to bump this package to v12.

And so I tried to package it, but hey, it requires a new dependency: https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/tree/v0.4.12

dh-make-golang gives me a good package straight, but hey, a new dependency: https://github.com/census-instrumentation/opencensus-proto/tree/v0.2.0

dh-make-golang give me a good package again, and this time this is the end of the game.

Based on that, I can finally ALMOST build Azure/go-autorest v12 (a test still fails).

So there's hope, I will push these 2 new packages to Salsa and ask for review.

Alternatively, one can have a look into Azure/go-autorest and try to patch things out to avoid these new depencies, maybe it's smarter than what I'm doing here: "blind packaging with dh-make-golang" ...

Cheers,

  Arnaud


Reply to: