On Wednesday, 20 November 2019 4:02:16 AM AEDT Martina Ferrari wrote:
> Could I ask you to also test with prometheus, disabling the
> 00-Disable_azure.patch patch?
What for?
Regardless of the outcome this should not block upload of azure-sdk-for-go.
Newer azure-sdk-for-go probably give you a better chance to adapt prometheus
than the old azure-sdk-for-go that you already know does not work...
Out of curiosity I've checked if prometheus builds without "00-
Disable_azure.patch" and with minor correction to "03-
Disable_kubernetes.patch" it FTBFS as follows:
~~~~
src/github.com/prometheus/prometheus/discovery/azure/azure.go:25:2: cannot
find package "github.com/Azure/azure-sdk-for-go/services/compute/mgmt/
2018-10-01/compute"
src/github.com/prometheus/prometheus/discovery/azure/azure.go:26:2: cannot
find package "github.com/Azure/azure-sdk-for-go/services/network/mgmt/
2018-10-01/network"
~~~~
Based on the above I recommend to ship at least "services/network" and
"services/compute" in the azure-sdk-for-go package.
Exposing the whole "services" needs the following libraries:
github.com/Azure/go-autorest/tracing
github.com/shopspring/decimal
github.com/globalsign/mgo
none of which are provided by any packages. "services" have 95 subfolders and
I'm not sure what would be the elegant way to ship just two of them without
maintaining long explicit exclusion list for DH_GOLANG_EXCLUDES.
Unfortunately "services/compute" (needed by prometheus) also depends on
"github.com/Azure/go-autorest/tracing" so at this moment we can not satisfy
prometheus's requirements without updating "golang-github-azure-go-autorest"
first.
I had a quick look and found that even latest release of the latter (v.
13.3.0 released in October) does not provide "github.com/Azure/go-autorest/
tracing" so we probably need to step back few versions of "azure-sdk-for-
go"...
--
Cheers,
Dmitry Smirnov.
---
The surest way to corrupt a youth is to instruct him to hold in higher
esteem those who think alike than those who think differently.
-- Friedrich Nietzsche
Attachment:
signature.asc
Description: This is a digitally signed message part.