[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#428884: bashism in init script fails to start nscd



On Thu, Jun 14, 2007 at 10:08:30PM +0000, Thorsten Glaser wrote:
> Package: nscd
> Version: 2.3.6.ds1-8
> Severity: important
> Tags: patch
> 
> Hi,
> 
> I've reported a similar bug to the sendmail-bin postinst script
> some time ago, you'll find it at
> | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=424213
> for reference and deeper information.
> 
> The script defines a shell function "stop()", however, all Korn
> shells have "stop" defined as builtin alias (unalias would work,
> but in the below patch, I've renamed the stop() function and,
> for consistency, the start() function).
> 
> Maybe someone should scan all Debian packages for that issue.


> I'd be appreciated if you apply the patch in a follow-up release,
> as Debian Policy states that scripts beginning with #!/bin/sh must
> be portable.

  It won't, the issue is not important at all, merely minor as it's a
problem with ksh that does not affect other shells. Also note that in a
shell, when you define a function, it should mask any builtin that
exists, so it's definitely a ksh only issue, and is not worth a stable
update.

  The fix will appear in the soon to be uploaded 2.6 packages though.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

Attachment: pgpIgULa0gW4E.pgp
Description: PGP signature


Reply to: