[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#361064: marked as done (glibc: [patch] make building glibc-2.4 without __thread support possible)

Your message dated Mon, 3 Jul 2006 07:16:09 +0200
with message-id <20060703051606.GA9165@bode.aurel32.net>
and subject line Closing the bug
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: glibc
Version: 2.3.999-1
Tags: experimental, patch

Hi,

the Hurd/Mach still has no TLS or __thread support.  This is not that
big of a problem as there is --without-tls, but glibc-2.4 uses __thread
unconditionally at one place and Ulrich Drepper refused to support
systems without __thread support (see
http://sourceware.org/ml/libc-alpha/2005-08/msg00091.html ).

The attached patch fixes building on system without __thread support
(i.e. hurd-i386), is it OK to apply to the 2.4 branch?


cheers,

Michael

# All lines beginning with `# DP:' are a description of the patch.
# DP: Description: Fix build when __thread is not available.
# DP: Dpatch author: Michael Banck <mbanck@debian.org>
# DP: Patch author: Thomas Schwinge
# DP: Upstream status: Rejected
# DP: Date: 2005-08-28

2005-08-28  Thomas Schwinge  <schwinge@nic-nac-project.de>

	malloc/memusage.c: Only use __thread if USE___THREAD.


Index: malloc/memusage.c
===================================================================
RCS file: /cvs/glibc/libc/malloc/memusage.c,v
retrieving revision 1.12
diff -u -r1.12 memusage.c
--- malloc/memusage.c	20 Aug 2005 01:12:37 -0000	1.12
+++ malloc/memusage.c	27 Aug 2005 23:43:02 -0000
@@ -83,7 +83,11 @@
 static memusage_cntr_t decreasing_mremap;
 static memusage_size_t current_heap;
 static memusage_size_t peak_use[3];
+#if USE___THREAD
 static __thread uintptr_t start_sp;
+#else
+static uintptr_t start_sp;
+#endif
 
 /* A few macros to make the source more readable.  */
 #define peak_heap	peak_use[0]

--- End Message ---
--- Begin Message --- 
This bug has been fixed, but tagged "fixed-experimental" instead of
being closed. As it only applies to experimental, I am closing it with
this mail.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

--- End Message ---
Reply to: