[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Glibc 2.3 pre-releases



On Tue, Sep 10, 2002 at 04:52:37PM +0100, Philip Blundell wrote:
> On Tue, 2002-09-10 at 15:04, Richard Zidlicky wrote:
> > --- glibc-2.2.90/sysdeps/m68k/dl-machine.h.rz	Mon Aug 26 11:44:44 2002
> > +++ glibc-2.2.90/sysdeps/m68k/dl-machine.h	Mon Aug 26 11:45:31 2002
> > @@ -311,6 +311,8 @@
> >    Elf32_Addr *const reloc_addr = (void *) (l_addr + reloc->r_offset);
> >    if (ELF32_R_TYPE (reloc->r_info) == R_68K_JMP_SLOT)
> >      *reloc_addr += l_addr;
> > +  else if (ELF32_R_TYPE (reloc->r_info) == R_68K_NONE)
> > +    return;
> >    else
> >      _dl_reloc_bad_type (map, ELF32_R_TYPE (reloc->r_info), 1);
> >  }
> 
> This is almost certainly a sign that you have bugs in the linker.  I'm
> not sure we should be putting this kind of patch into glibc.

There are two cases where people have been trying to add R_*_NONE
workarounds to glibc.  That looks like it's handling PLT relocations rather
than general relocations, which means that almost certainly a PLT entry
was not emitted that should have been.  I think I know why; give me a
day or two to check if the problem I found also affects M68K.  I'll
post the ARM patch also.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



Reply to: