[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: jeolib-jiplib



I've pushed a bunch more changes to fix most of the issues I encountered, that more helpful than my harsh review.

Most prominent issue left is remnants of the RPATH:

 I: libjiplib1: file-references-package-build-path [usr/lib/x86_64-linux-gnu/libjiplib.so.1.1.5]
 I: python3-jiplib: file-references-package-build-path [usr/lib/python3/dist-packages/jiplib/_jiplib.cpython-313-x86_64-linux-gnu.so]

Details:

 $ strings /tmp/libjiplib1/usr/lib/x86_64-linux-gnu/libjiplib.so.1 | grep '/build/'
 ${ORIGIN}:/build/jeolib-jiplib-1.1.5+ds/build

 $ strings /tmp/python3-jiplib/usr/lib/python3/dist-packages/jiplib/_jiplib.cpython-313-x86_64-linux-gnu.so | grep '/build/'
 ${ORIGIN}:/build/jeolib-jiplib-1.1.5+ds/build

Caused by:

 SET(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
 SET(CMAKE_INSTALL_RPATH "$\{ORIGIN\}:${CMAKE_CURRENT_BINARY_DIR}")
 SET(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)

chrpath doesn't strip those.

Using CMAKE_SKIP_RPATH might work but that causes the tests to fail because libjiplib.so.1 cannot be found despite LD_LIBRARY_PATH, not sure what's going on there. Might have to settle for a lintian override.

Kind Regards,

Bas

--
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


Reply to: