On 3/27/25 10:01 AM, Francesco P. Lovergine wrote:
I finally managed to prepare a decent version of the following library
and its Python binding with extension.
Your work was invisible because you did not use the procedure documented in the team policy which ensures that repo is configured correctly:
https://debian-gis-team.pages.debian.net/policy/packaging.html#git-repository-on-salsa
I've fixed the configuration using the salsa-configure-repositories.pl script.
Anyone knows why I had to override
a dh_numpy3-related error that is strangely signaled by current lintian? It
seems a lintian issue...
You're not using the dh sequences for python3 & numpy.
The libjiplib1 package name is also wrong for a Python package.
The lib package should only provide the shared library and a separate python3-jiplib binary package the Python bits.
As for previous stuff, I'm in contact with Pieter for possible changes in
upstream side.
As always comments/cotributions and pointings to my oversights are very welcome...
debian-branch is not conformant to our team policy (we use master, not main)
https://debian-gis-team.pages.debian.net/policy/repositories.html#git-branches
debian/copyright formatting is inconsistent with the rest of the teams packages.
Not using standalone license paragraphs.
Wrong shortname for BSD-3-clause license.
Invalid syntax for test/pytest*.py section (Copyright field used for License).
debian/libjiplib1.dirs & debian/libjiplib-dev.dirs are useless.
debian/libjiplib1.lintian-overrides syntax is not conformant, and lacks comment.
See: https://salsa.debian.org/debian-gis-team/gdal/-/blob/master/debian/python3-gdal.lintian-overrides?ref_type=heads
debian/rules doesn't use execute_{before,after}.
override_dh_shlibdeps is wrong for dh_numpy3, override_dh_python3 is better, but dh-sequence-numpy build dependency is correct.
Don't shell out to dpkg-architecture, use the Makefile includes provided by dpkg.
debian/patches/pip-break-sys-pkg.patch, try to not use CMake for the Python bits, use pybuild instead.
debian/upstream/metadata contains useless comment and empty line.
debian/watch not handling common issues like our other packages.
Reviewing this package depressed me. You should know better. Don't reinvent the wheel, look at other packages in the team for examples.
I've pushed changes for some of the issues I encountered, but it needs a lot more work before it's acceptable.
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1