[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: GeoPandas 1.0.0



On 6/29/24 11:06 AM, Antonio Valentino wrote:
Just pushed the source code for the pyogrio debian package to salsa.

That's most excellent, thanks for your work on this.

Please feel free to review and upload.

I've pushed a few fixes as the package is not maintained in the science-team, not using a standalone license paragraph for the public-domain files as the remaining lines must explain the exemption, and enabled the test-build-twice Salsa CI job to catch incomplete clean targets, before sponsoring the upload.

* some of the data files has been removed because the license was not clear (see also discussion in https://github.com/geopandas/pyogrio/issues/433)

Great.

* the pyogrio package as a build dependency (for testing only) on geopandas leading to a kind of circular dependency. It think that it is manageable as it is, but if you think it is safer to remove the dependency on geopandas I can quickly do it

As a test-only dependency it's probably all right, we'll break the circular dependency if that turns out to be wrong.

Kind Regards,

Bas

--
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


Reply to: