[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] Pooch and donfig



On 8/21/21 6:38 PM, Antonio Valentino wrote:
> OK, I think the I have fixed all issues.
> Regarding tests skipped for pooch, the reason is that about half of the
> tests make attempt to access to the interned which results in a failure
> in the debian build environment.
> 
> Do you have any recommendation?

Use pytest.mark and skip those is a common way to skip network tests,
see cartopy for example. If the bulk of the test suite requires network,
there is probably little value to only run the few remaining ones.

> Also some of the tests depend on pytest-localftpserver which seems to be
> not available in debian.

It could be packaged as well, but I wonder if it warrants the effort.


donfig has a few useless substvars:

 dpkg-gencontrol: warning: Recommends field of package python3-donfig:
substitution variable ${python3:Recommends} used, but is not defined
 dpkg-gencontrol: warning: Suggests field of package python3-donfig:
substitution variable ${python3:Suggests} used, but is not defined

pooch does too:

 dpkg-gencontrol: warning: Recommends field of package python3-donfig:
substitution variable ${python3:Recommends} used, but is not defined
 dpkg-gencontrol: warning: Suggests field of package python3-donfig:
substitution variable ${python3:Suggests} used, but is not defined

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


Reply to: