[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fwd: Bug#958047: RFS: mercantile/1.0-1 [ITP] -- python3-mercantile - Web mercator XYZ tile utilities



On 4/22/20 8:44 PM, Joachim Langenbach wrote:
>> Have a look at the Vcs-* fields in d/control, that's where the repo
>> should be, but it currently is not, it's at [1].
> 
> Now they are the correct urls ;-) Do I need to rebuild the package or is it 
> ok, like it is?

The package needs to be reviewed, most likely some changes will be
required. I don't have time for a review today, maybe tomorrow or Friday.

The first thing I did notice was an old changelog entry that should
likely be merged, you're the one closing the ITP.

> One question: The watch file is pointing to the upstream github repository. 
> Should it point to the salsa repository?

No, the watch file is used to monitor for new upstream releases and to
download them.

 https://debian-gis-team.pages.debian.net/policy/packaging.html#git-new-upstream

Compare the output of `uscan --verbose --report` with what the package
has now and what it is when you change it to salsa.

Regarding watch files and Python projects. A git repo (assuming they
have proper release tags) is better than using PyPI, as sdist tends to
miss files because it requires maintaining MANIFEST.in. And there is no
need to exclude generated files like the .egg-info directory.

See for example the differences between the packaging for pyshp which
uses PyPI, and python-rtree which uses GitHub releases.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1


Reply to: