[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: OpenStreetMap Software



On Do, Apr 10, 2014 at 11:38:50 +0200, Sebastiaan Couwenberg wrote:
> > Also there is one problem I can see: The osmosis binary doesn't know its own
> > version. There is some magic in build.gradle that figures out the version
> > string from the git tag/commit. For some reason this generates an empty
> > VERSION string in the Debian built. You can see the result when calling
> 
> The Debian source package doesn't contain the git repository, so auto
> detecting the version with git won't work.
> 
> To fix the version detection, I've added a patch to use a simple shell
> script to extract the upstream version from the debian/changelog. Groovy
> execute() only supports single commands, so you can't just run the
> typical shell one-liner instead of the git command.

Looks good.

> Additional patches for the changes from the master branch of the osmosis
> git repository are also included now. I have my doubts if the pgsnapshot
> changes are appropriate, I'm tempted to drop those from the package
> again. My interest is mostly in the 64-bit fix, and the null-pointer
> exception fix.

The pgsnapshot stuff looks more or less harmless. Mostly changes to what
is done by default and what not. All of this is something people have to
edit anyway for their local needs.

> I've also figured out how to fix the checkstyle and jdepend dependencies
> in the gradle build, so those tasks are no longer excluded.
> 
> The test task is still excluded because the database is not available.
> Adding the postgis setup for osmosis to debian/rules shouldn't be much
> of an issue, it's next on my list.

Okay.

Jochen
-- 
Jochen Topf  jochen@remote.org  http://www.jochentopf.com/  +49-721-388298


Reply to: