[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: Grits - Virtual Globe library

On 2011-07-26 11:35, Julian Taylor wrote:
> it does not build in a clean pbuilder environment:
> ../../doltcompile gcc -DHAVE_CONFIG_H -I. -I../..    -Wall --std=gnu99
> -I../../src -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>   -pthread -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0
> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
> -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo
> -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/
> -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread
> -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12
> -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>   -fPIC -g -O2 -c -o grits-object.lo grits-object.c
> grits-object.c:33:19: fatal error: GL/gl.h: No such file or directory
> ..
> grits-poly.c:27:20: fatal error: GL/glu.h: No such file or directory
> ...

Added Build-Depends on mesa-common-dev and libglu1-mesa-dev.

> if that is fixed:
> gcc: error: unrecognized option '--as-needed'
> you are patching Makefile.am but not regenerating it, use dh $@ --with
> autoreconf (+ a build depend on dh-autoreconf) or patch Makefile.in

Changed the rules file to use autoreconf and added a build depend on

It build now in pbuilder.

> debian/copyright:
> Files: is a required DEP5 tag, add a Files: * if the copyright covers
> all files

Added Files: *

> debian/watch:
> the regex is probably a bit to generic
> http://lug.rose-hulman.edu/proj/grits/libgis-([\d.]+)\.tar\.gz
> may be better

Changed to http://lug.rose-hulman.edu/proj/grits/grits-([\d.]+)\.tar\.gz

> some shlibs warnings:
> dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/test.so
> contains an unresolvable reference to symbol g_type_check_class_cast:
> it's probably a plugin.
> ...
> If they aren't plugins they shuold link against what they need to not
> create problems in --as-needed builds.

These are plugins.

> optional:
> even with the as-needed there seems to be some unnecessary linkage, is
> the flag used correctly (its positional)?
> multiarch is now possible in debian. Consider enabling a multiarch build:
> http://wiki.debian.org/Multiarch/Implementation

I'd like to do both of these, but I think I'll put them off until the
next release. I'd like to get something out now and then improve it

> run wrap-and-sort from ubuntu-dev-tools for some nice formating of debian/

I've updated some of the formatting (and wrapped some text), but I think
I'm going to leave some of the formatting the way it is since I think
it's better than what wrap-and-sort does ;)

Attachment: pgp7FnRCs2k1b.pgp
Description: PGP signature

Reply to: