Re: [DebianGIS] TileCache 2.0 debian packaging
On Dec 23, 2007 12:23 PM, Christopher Schmidt <crschmidt@metacarta.com> wrote:
> Approximately 8 months ago, Paul Wise offered a great review of the
> TileCache Debian packaging materials with an eye towards inclusion in
> Debian.
>
> http://lists.alioth.debian.org/pipermail/pkg-grass-general/2007-April/002565.html
>
> Since then, TileCache has been released another 6 times, but no serious
> effort had been made on improving packaging until today.
>
> http://svn.tilecache.org/trunk/tilecache/ has the updated code with the
> changes I mention below implemented.
A review of the current SVN:
May as well drop the make clean from debian/rules since it isn't used.
The two latest debian/changelog entries miss blank lines in the right places.
The debian/changelog is meant only for packaging related changes.
No need to build-dep on sed, that should be present on all systems.
Homepage is now a real field: http://wiki.debian.org/HomepageFieldHOWTO
> > * copyright: move "Copyright (c) 2006-2007 MetaCarta, Inc." into the
> > copyright holder section
> Done, I think?
Well, you copied it rather than moved it, so I don't think that this
is fixed. License != Copyright, the licence goes in the licence
section and the copyright in the copyright section :)
TileCache/Services/*, TileCache/Caches/*, TileCache/Layers/* don't
seem to have the copyright lines.
TileCache/Caches/S3.py is copyright by Amazon and has a different
licence, you should mention that separately in debian/copyright and
maybe in the upstream docs too
I also think that you should instead depend on python-boto and use the
S3 support from that maybe. If you don't want to do that and the S3.py
code is also in python-boto, please make sure you notify the security
team about the code duplication.
Is there any reason that upstream and Debian shouldn't both use
/usr/sbin or /usr/bin - making Debian different to other distros
wouldn't really be good.
Likewise for the manpages - I assume users of BSD and other GNU/Linux
distros would also appreciate manual pages.
> > * CHANGELOG: seems like the kinda thing that should be called NEWS
> > instead, may want to generate a ChangeLog with svn2cl
>
> A commit by commit changelog seems unneccesary to me. "CHANGELOG" seems
> to be what Debian calls its 'overall list of things changed between
> releases' file -- why is this different?
I read the GNU standards before I joined Debian - there the summary of
changes between releases is in NEWS and the log of individual changes
is in ChangeLog.
This convention is by no means adopted by free software as a whole, or
even remotely consistent, except perhaps among GNU software and
software influenced by GNU and automake/autoconf.
Also docs/CHANGELOG.txt is missing the 2.0 version.
I notice that during the build process (in a cowbuilder chroot), it
downloads and installs a setuptools egg. Doing anything that requires
network access during the build process is a big no-no.
Is it appropriate to run the tests during the build process or do they
require network access?
lintian errors/warnings/info:
E: tilecache source: debian-rules-missing-required-target binary-arch
W: tilecache source: out-of-date-standards-version 3.7.2 (current is 3.7.3)
E: tilecache source:
build-depends-on-essential-package-without-using-version
build-depends: sed
I: tilecache source: build-depends-without-arch-dep python
I: tilecache source: build-depends-without-arch-dep python-support
I: tilecache source: build-depends-without-arch-dep sed
W: tilecache: description-contains-homepage
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: