Re: [DebianGIS] GRASS 6.0.1 for sarge and on-going work...
On Wed, Sep 14, 2005 at 10:46:49PM +0200, Francesco Paolo Lovergine wrote:
> On Wed, Sep 14, 2005 at 03:26:41PM -0400, Steve Halasz wrote:
> > On Wed, 2005-09-14 at 16:42 +1200, Hamish wrote:
> > > I notice that the new 6.0.1 grass package is missing the r.terraflow
> > > module (configure --with-cxx).
> > >
> > >
> > > The control file in
> > >
> > > http://pkg-grass.alioth.debian.org/debian-gis/pool/g/grass/grass_6.0.1-0.dgis.stable.2.diff.gz
> > >
> > > includes --with-cxx but I don't see the r.terraflow module in the
> > > binary. The GRASS build system is set up so an individual module can
> > > fail to build but that won't break the overall build. Need to check
> > > error.log after it's done for any errors. Usually if there was an error
> > > you would then cd to the module's directory and re-run make to see what
> > > the error was.
> >
> > There is a --without-cxx later on that overrides it. This was to prevent
> > it building due to the tmp file security problem which is maybe fixed
> > now(?). Just need to remove that and it should work.
> >
> > Steve
> >
>
> Eh, better to check it. I downloaded 6.0.1-1 with --with-cxx enabled, looking into
> the issue...
>
Well, as already pointed by Hamish previously, raster/r.terraflow/IOStream/lib/src/ami_stream.cc
uses mkstemp() to atomically create a temporary file under /var/tmp, so
that issue is a non-one currently. That code needs also some
refinement, due to wide use of deprecated sprintf(). AFAIK, but for
snprintf(), GRASS has his own G_asprintf() which is also better and
portable. But that's an upstream issue anyway...
--
Francesco P. Lovergine
Reply to: