[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#774274: Bug#774274: fontforge: please use SOURCE_DATE_EPOCH for reproducible font modification time

Justin Cappos <jcappos@nyu.edu> writes:

> found 774274
> forwarded 774274 https://github.com/fontforge/fontforge/issues/2490
> done
> The changelog doesn't seem to indicate that the upstream patch was
> applied.  This seems to be fixed in upstream master on November 16th, 2016
> as per ( https://github.com/fontforge/fontforge/issues/2490 ).

The commit you mentioned in above pull request is already in Debian
package ¹. It was merged by upstream and not patched by us in Debian
hence not mentioned in changelog.

¹ https://anonscm.debian.org/cgit/pkg-fonts/fontforge.git/commit/fontforge/tottf.c?id=3d6c16da24d8ae105dfbb3c3a0e0e507e04b835d

> This may or may not address / relate to
> https://github.com/fontforge/fontforge/issues/2943.  The issues seem to
> contradict each other about whether the same merged patch set addresses
> both.

Well its Debian's patch which got merged please see first commit in the
PR its mine and taken from Debian patch I created which is already
included in fontforge. ²

² https://anonscm.debian.org/cgit/pkg-fonts/fontforge.git/tree/debian/patches/1001_reproducibe_buildtimestamps.patch

> This comes up as an issue with many packages (e.g.,
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/dkg-handwriting.html
> seems to be impacted by 2490 and

I don't think its impacted by 2490 the message clearly suggest a new
patch is in WIP at ³ Also 2490 related one patch is already into
fontforge. Once the below WIP patch is submitted upstream I will happily
merge it in our packaging.

³ https://gist.githubusercontent.com/lamby/60a545b37b778e148702c342bbf86bd9/raw/19a39af51d669fde042b261236f65ba72f75662a/903_reproducubile_build.diff

> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/essays1743.html
> seems to be impacted by 2943 ).

Not really sure about this also because related patch is already in

I'm not really experienced in reproducible builds so I'm just pointing
at things which are already included in package. If more things needs to
be included please let me know I will get included those in the pacakge.


Reply to: