[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#489567: dpkg-cross: bashism in /bin/sh script



Package: dpkg-cross
Severity: important
Version: 2.2.4
User: debian-release@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing one or more /bin/sh scripts making 
use of bashisms.

checkbashisms' output:
> possible bashism in ./usr/share/bug/dpkg-cross/script line 17 (echo -e):
>                 echo -e "\n-- dpkg-cross2.log --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 20 (echo -e):
>                 echo -e "\n-- (no dpkg-cross2 logfile present) --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 23 (echo -e):
>                 echo -e "\n-- gccross2.log --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 26 (echo -e):
>                 echo -e "\n-- (no gccross2 logfile present) --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 33 (echo -e):
>                 echo -e "\n-- $HOME/.dpkg-cross/cross-compile --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 36 (echo -e):
>                 echo -e "\n-- ( $HOME/.dpkg-cross/cross-compile present,
> but not submitted) --\n" >&3 
> possible bashism in ./usr/share/bug/dpkg-cross/script line 42 (echo -e):
> echo -e "\n-- /etc/dpkg-cross/cross-compile --\n" >&3
> possible bashism in ./usr/share/bug/dpkg-cross/script line 45 (echo -e):
>         echo -e "\n-- (/etc/dpkg-cross/cross-compile not submitted) --\n"
> >&3

Not using bash (or a Debian Policy conformant shell interpreter which does 
provide such an extra feature) as /bin/sh is likely to lead to errors or 
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there's a 
release goal for Lenny to make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information please refer to the Debian Policy section 10.4 supporting 
this argument at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



Reply to: