[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#958955: Update package description wrt Puppet 3

On Tue, Apr 28, 2020 at 08:57:39PM -0400, Nicholas D Steeves wrote:
> Control: tag -1 upstream
> Hi Moritz,
> Moritz Muehlenhoff <jmm@debian.org> writes:
> > Source: puppet-mode
> > Version: 0.4-1
> > Severity: minor
> >
> > The short description currently reads "major mode for Puppet 3 manifests in Emacs",
> > which sounds as if the support were limited to older Puppet versions, let's
> > simply use "major mode for Puppet manifests in Emacs"? After all the mode supports
> > keywords of the current 5.x releases just fine.
> >
> I'm not sure why the upstream description specifies "Puppet 3", but if I
> had to speculate it might be because 0.4 doesn't support all Puppet 5
> keywords.  Do you know if support for Puppet 5 manifests is complete in
> this version?

https://github.com/voxpupuli/puppet-mode/pull/106 and
https://github.com/voxpupuli/puppet-mode/pull/107 added support for
Puppet type annotations and keywords from 5.3, so this seems complete.

I've been using this mode with a Puppet repository based on 5.5.10
(as shipped in Debian buster) and I haven't noticed any missing
keywords or syntax elements, so from my PoV this seems to support
Puppet 5 just fine.

> At any rate, would you like to open an upstream issue, or would you
> prefer if I do so?

Ack, I just did that at https://github.com/voxpupuli/puppet-mode/issues/124


Reply to: