Package: php-elisp
Version: 1.21.0-1
Severity: normal
Hi Antoine,
Thank you for much for sponsoring src:php-elisp! I've created a
tracking bug for these issues, replied inline, and plan to fix them in
the next upload.
On Sat, Feb 02, 2019 at 12:40:40PM -0500, Antoine Beaupré wrote:
> I uploaded the package, but I'll note some improvements that could be
> done on it:
>
> 1. newer versions of debhelper allow deduplicating information between
> the control file and debian/compat. just remove the latter and
> change the control dependency to "debhelper-compat (=11)" (or
> 12). see also:
>
> https://nthykier.wordpress.com/2019/01/04/debhelper-compat-12-is-now-released/
Oh! Thank you for telling me about this :-) (I didn't know)
> 2. very minor, but i like to keep the "transitional package" phrase on
> a separate line in package descriptions so it's more obvious to
> someone looking at the description
Do you mean like this?:
Short description: transitional package from old-foo to new-foo package
Old-foo description, and why new-foo...
.
This is a transitional dummy package and can be safely removed.
> 3. why was the php-root self-test disabled? what's the next step for
> that patch? can it be sent upstream or will we have to carry this on
> forever?
(ert-deftest php-project-root ()
(should (string= (abbreviate-file-name default-directory)
(php-project-get-root-dir))))
Evals to "/<<PKGBUILDDIR>>/" instead of the real path. It will take
some time to review the changelogs and git history of my other
packages to find the workaround for this sbuild/buildd quirk, because
I didn't write "PKGBUILDDIR" as a keyword the last time I ran into it.
Oops... Thus, I confess to choosing the fastest/easiest path since
the freeze is so close.
> Thanks for your work! :)
You're welcome :-D
--
Nicholas
Attachment:
signature.asc
Description: PGP signature