Re: Need help converting ess package to melpa-ess

[David Bremner <david@tethera.net>]

Dirk Eddelbuettel <edd@debian.org> writes:

> I opted for that second solution (including your attached el as well), but no
> mas. It still bonks on load.
>  
> | Basically the ;;;###autoload tells emacs to include the next form in the
> | generated autoloads file.
> | 
> | There are two remaining issues, which seem more specific to ess.
> | 
> | ,----
> | | In toplevel form:
> | | ess-bugs-d.el:26:1:Error: Symbol’s value as variable is void: ess-microsoft-p
> | `----
> | 
> | I don't know how this works normally, but I found that adding "(require
> | 'ess-custom)" to the top of ess-bugs-d.el fixed it.
>
> I ignored that for now; I seem to recall that some of these things changed upstream.

I don't think that error is ignorable, it's causing the postinst to
fail. I cloned your repo from upstream, applied the following patch, and
the resulting package installs for me.

diff --git a/lisp/ess-bugs-d.el b/lisp/ess-bugs-d.el
index a3bba7d..9c0230d 100644
--- a/lisp/ess-bugs-d.el
+++ b/lisp/ess-bugs-d.el
@@ -23,6 +23,7 @@
 
 ;;; Code:
 
+(require 'ess-custom)
 (require 'ess-bugs-l)
 (require 'ess-utils)
 (require 'ess-inf)