Re: Reproducible builds for fwupdate
On Fri, Apr 15, 2016 at 08:56:38PM +0000, Mario_Limonciello@Dell.com wrote:
>> -----Original Message-----
>> From: Steve McIntyre [mailto:steve@einval.com]
>> Sent: Thursday, April 14, 2016 6:49 PM
>> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
>> Cc: debian-efi@lists.debian.org
>> Subject: Re: Reproducible builds for fwupdate
>>
>> Gah, missed this in my inbox - sorry!
>>
>> On Wed, Apr 06, 2016 at 10:48:54AM -0500, Mario_Limonciello@Dell.com
>> wrote:
>> >Hi,
>> >
>> >I was really hoping to make fwupdate's build fully reproducible in the
>> >last upload, but it seems it still failed on the PO file:
>> >https://tests.reproducible-builds.org/rb-pkg/unstable/amd64/fwupdate.ht
>> >ml
>> >
>> >I had tried to fix this with
>>
>> http://anonscm.debian.org/cgit/uefi/fwupdate.git/commit/?id=d498e174b6
>> 3c439e73a64b10ca3937f9f4901a1d
>> but that seems to have still not done the trick.
>> >
>> >To me this looks like it might be a matter of a TZ variable from the
>> >buildd leaking into the environment. Could I get another set of eyes
>> >whether this fix should do the trick to resolve in the next upload?
>> >
>> >diff --git a/debian/rules b/debian/rules index 6181785..1cd009f 100755
>> >--- a/debian/rules
>> >+++ b/debian/rules
>> >@@ -3,7 +3,7 @@
>> >
>> >DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -
>> qDEB_HOST_MULTIARCH)
>> >EFIDIR ?= $(shell dpkg-vendor --query vendor | awk '{ print
>> >tolower($$0) }') -PODATE := $(shell dpkg-parsechangelog --show-field
>> >Date | xargs -0 date "+%Y-%m-%d %H:%M%z" --date)
>> >+PODATE := $(shell dpkg-parsechangelog --show-field Date | xargs -0
>> >+date --utc "+%Y-%m-%d %H:%M%z" --date)
>>
>> I'd just use "-u" rather than "--utc" normally, but this looks like it should help
>> yes!
>
>OK thanks. I've staged an upload for that and a few other things,
>can you sponsor?
In incoming now.
--
Steve McIntyre, Cambridge, UK. steve@einval.com
Welcome my son, welcome to the machine.
Reply to: