[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1057815: debian-edu-artwork-emerald: modifies conffile: /etc/plymouth/plymouthd.conf



Package: debian-edu-artwork-emerald
Version: 2.12.3-2
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts
Control: found -1 2.12.3-2~deb12u1

Hi,

during a test with piuparts I noticed your package modifies conffiles.
This is forbidden by the policy, see
https://www.debian.org/doc/debian-policy/ch-files.html#configuration-files

10.7.3: "[...] The easy way to achieve this behavior is to make the
configuration file a conffile. [...] This implies that the default
version will be part of the package distribution, and must not be
modified by the maintainer scripts during installation (or at any
other time)."

Note that once a package ships a modified version of that conffile,
dpkg will prompt the user for an action how to handle the upgrade of
this modified conffile (that was not modified by the user).

Further in 10.7.3: "[...] must not ask unnecessary questions
(particularly during upgrades) [...]"

If a configuration file is customized by a maintainer script after
having asked some debconf questions, it may not be marked as a
conffile. Instead a template could be installed in /usr/share and used
by the postinst script to fill in the custom values and create (or
update) the configuration file (preserving any user modifications!).
This file must be removed during postrm purge.
ucf(1) may help with these tasks.
See also https://wiki.debian.org/DpkgConffileHandling

In https://lists.debian.org/debian-devel/2012/09/msg00412.html and
followups it has been agreed that these bugs are to be filed with
severity serious.

debsums reports modification of the following files,
from the attached log (scroll to the bottom...):

/etc/plymouth/plymouthd.conf


Note that this bug is only easily reproducible in piuparts tests
with --install-recomends enabled. (It requires a certain combination of
packages (that are only linked via Recommends) to be installed
concurrently.)

This bug wasn't present in bookworm initially, but is now being
introduced via -pu.

This bug did not exist with pre-bookworm releases.

Since all other theme configuration is handled via alternatives, why
can't the same be done with plymouth? (It may require some packaging
changes on the plymouth side, though).


cheers,

Andreas

Attachment: debian-edu-artwork-emerald_2.12.3-2.log.gz
Description: application/gzip


Reply to: