On Sun, Jan 27, 2019 at 10:37:09PM +0100, Petter Reinholdtsen wrote:
> [Holger Levsen]
> > 13b6dab8 by Holger Levsen at 2019-01-27T16:57:58Z
> > 032-edu-pkgs: merge those ten apt-get purge calls into one.
> This is a very bad idea. The calls was written like that to "fail"
> individually, in case some packages were missing in the chroot. By
> joining them together, any missing package will stop the entire purging
> from happening.
that's why it ends with || true now.
(I also thought about whether thats a good idea but concluded yes.
quoting myself from irc: apt purge $pkg takes 14secs on my computer,
mostly because of those triggers. so i assume 13b6dab might have reduced
installation time by a minute :)
we can and will notice failures to purge in the logfiles during
development, and then we can also address those.
--
tschüß,
Holger
-------------------------------------------------------------------------------
holger@(debian|reproducible-builds|layer-acht).org
PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
Attachment:
signature.asc
Description: PGP signature