[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858643: desktop-base: File not found in the post-inst script



control: reassign -1 desktop-base
control: found -1 9.0.3
control: tags -1 - moreinfo

Hi Wolfgang,

Le 01/07/2017 à 15:43, Wolfgang Schweer a écrit :
> Hi,
> 
> On Sat, Jul 01, 2017 at 01:39:07PM +0200, Andreas Beckmann wrote:
>> Followup-For: Bug #858643
>  
>> I could also reproduce this with piuparts in a stable -> testing ->
>> unstable upgrade test.
>  
> IMO it's a desktop-base bug; see 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858643#63
> for a proposed patch.
> 
> @ Aurélien
> 
> Any progress fixing it? See your mail: 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858643#29

I had missed it was for post stretch upgrade last time I looked into
this, so I hadn’t come to any conclusion.

I initially thought we could "just" patch debian-edu-artwork to ship an
SVG versions of the edu-spacefun wallpaper, but there’s no such thing in
the source repository even going back in time to squeeze. There are SVGs
for edu-spacefun but they look like imports from bitmap with vain
attempts to make them vector…
By itself it’s a problem since it means these wallpapers are essentially
sourceless and we cannot easily adapt them should the need arise (higher
resolution, etc).

Anyway we should never break on upgrade for even if the active theme
pack is incomplete, I’m thus reassigning the bug to desktop-base and
will conditionally create the alternatives for the active theme only if
the target exists in that theme.

Also I can see the rationale of theme packs providing a bitmap
background instead of SVG, if it’s based on a photo for instance.
Currently desktop-base doesn’t provide an easy way to support that.

What I can think of is for each theme pack to provide a
"default-wallpaper" symlink to their wallpaper file of choice and the
desktop-background alternative will target link for the active theme, so
it works whatever wallpaper/resolution/format the theme wants as default.
For buster I’ll create the links for the themes included in desktop-base
and the *all* debian-edu-artwork-* themes should do the same.
That would be for example with softwaves:
  softwaves-theme/wallpaper/contents/images$ ls -l
  1920x1080.svg
  default-wallpaper -> 1920x1080.svg
  …
and second example with debian-edu-spacefun:
  debian-edu-spacefun-theme/wallpaper/contents/images$ ls -l
  1920x1080.png
  default-wallpaper -> 1920x1080.png
  …

Would that be OK with you ?


On a side note I don’t like very much the concept of a single wallpaper
image that the "desktop-background" alternative provides. It cannot
support various screen sizes and ratios correctly.
Gnome or KDE Plasma get it right by selecting one among n possible
resolutions to match the screen size at runtime, but getting this done
for all Desktop Environments seems far-fetched.
If anyone from other DEs is listening and want to use either
/usr/share/gnome-background-properties/*.xml or KDE Plasma’s
/usr/share/wallpaper structure, don’t refrain. :)


Cheers,
--Aurélien


Reply to: