[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [debian-edu-commits] debian-edu/ 07/07: testsuite/webserver: Dito (check presence of cert_override.txt in /etc/firefox-esr/, rather than /etc/firefox/).



On Fri, Jul 08, 2016 at 09:26:23AM +0200, Wolfgang Schweer wrote:
> > sunweaver pushed a commit to branch master
> > 
> > commit 9a8b162f2ef21770a8a45f67aab1c9076122c8ef
> 
> [..]
> 
> > -overridefile=/etc/firefox/profile/cert_override.txt
> > +overridefile=/etc/firefox-esr/profile/cert_override.txt
> >  if [ ! -f "$overridefile" ] ; then
> >      echo "error: $0: Missing $overridefile."
> >  else
> 
> The profile subdir doesn't exist by default. So the test(s) will report 
> an error. Even if the profile subdir is created, the cert_override.txt 
> file will not be respected. AFAICT this location for the 
> cert_override.txt file is gone since some time.
> But, as the cert_override.txt file is available in /etc/skel on tjener,
> the intended cert overriding is working cause the file is
> copied to each user's firefox profile dir.
> 
> IMO both webserver and ltsp tests should be adjusted. And cf.firefox-esr
> as well…

sounds good, can you please do this in the master branch?

On Fri, Jul 08, 2016 at 09:36:40AM +0200, Wolfgang Schweer wrote:
> > sunweaver pushed a commit to branch jessie
> > in repository debian-edu-config.
> > 
> > commit db38335bf2ef3eb20666af3c19e2af1c8db55aae
> 
> >  # Write the override entries in the default profile.
> >  # These will be copied to new Firefox profiles.
> >  
> > -OVERRIDE_FILE=/etc/firefox/profile/cert_override.txt
> > +OVERRIDE_FILE=/etc/firefox-esr/profile/cert_override.txt
> 
> Same here as reported for testsuite/webserver and testsuite/ltsp.
> 
> IMO this location is deprecated / overriding doesn't work anymore this 
> way.
 
ack.

and this needs to be done in master and jessie branches…

Thanks for noticing!


-- 
cheers,
	Holger

Attachment: signature.asc
Description: Digital signature


Reply to: