[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [debian-edu-commits] debian-edu/ 01/01: share/d-e-c/tools: Add scripts 'install-missing-taskpkgs' and 'install-missing-chroot-taskpkgs'; they do what their names tell and are esp. useful after distribution upgrade when packages from the task files are missing due to meta-packages not allowing to define real Depends. (Closes: #779644, #779647, #779648).

On Wed, Mar 18, 2015 at 02:36:32PM +0100, Petter Reinholdtsen wrote:
> I had a quick look at this branch, and the approach look good, but the
> check_desktop_task() function seem redundant and its use of debconf to
> guess which tasks to look for is only safe to do during installation.
> Afterwards, admins might have installed other desktop tasks.  I suggest
> to remove the code using it completely, as it is only misleading as it
> currently stand.

Thanks for the feedback. Checks are now removed completely.
> The use of echo here is useless:
>   for i in $(echo $unwanted); do
> Just write this instead:
>   for i in $unwanted; do


> Btw, it seem strange to me that munin-node resolvconf, readahead-fedora,
> lvm2 and popularity-contest is no longer wanted in jessie.  How did you
> create that list of packages to remove?  If it is only for LTSP, perhaps
> use a different variable name?  Also, I suggest one package per line, to
> make it easier to track changes in git.

Done. Comment about the list of packages improved. 


Attachment: signature.asc
Description: Digital signature

Reply to: