Re: Bug#762906: krb5-auth-dialog debug output

[Guido Günther <agx@sigxcpu.org>]

On Mon, Oct 20, 2014 at 09:42:29AM +0200, Guido Günther wrote:
> Hi Wolfgang,
> On Sun, Oct 12, 2014 at 07:35:13PM +0200, Wolfgang Schweer wrote:
> > On Sun, Oct 12, 2014 at 10:00:32AM +0200, Guido Günther wrote:
> > > 
> > > ...and the process keeps runnng? Is that all the output you're seeing?
> > > IN that case that's probably not the debug build.
> > 
> > You're right, ran it on the wrong vm. This is the output using the debug
> > build:
> > 
> > test@tjener:~$ killall -s9 krb5-auth-dialog
> > test@tjener:~$ krb5-auth-dialog
> > 
> > ** (krb5-auth-dialog:3265): WARNING **: Couldn't register with 
> > accessibility bus: Did not receive a reply. Possible causes include: the 
> > remote application did not send a reply, the message bus security policy 
> > blocked the reply, the reply timeout expired, or the network connection 
> > was broken.
> > DEBUG: ka_applet_set_property: principal: 
> > DEBUG: ka_applet_set_property: pk-userid: 
> > DEBUG: ka_applet_set_property: pk-anchors: 
> > DEBUG: ka_applet_set_property: pw-prompt-mins: 30
> > DEBUG: ka_applet_set_property: tgt-forwardable: False
> > DEBUG: ka_applet_set_property: tgt-proxiable: False
> > DEBUG: ka_applet_set_property: tgt-renewable: False
> > DEBUG: ka_applet_set_property: conf-tickets: False
> > DEBUG: ka_applet_set_property: principal: 
> > DEBUG: ka_applet_set_property: pk-userid: 
> > DEBUG: ka_applet_set_property: pk-anchors: 
> > DEBUG: ka_applet_set_property: pw-prompt-mins: 30
> > DEBUG: ka_applet_set_property: tgt-forwardable: False
> > DEBUG: ka_applet_set_property: tgt-proxiable: False
> > DEBUG: ka_applet_set_property: tgt-renewable: False
> > DEBUG: ka_applet_set_property: conf-tickets: False
> > DEBUG: ka_applet_local_command_line: Parsing local command line
> > DEBUG: ka_applet_startup: Primary application
> > DEBUG: ka_nm_client_state_changed_cb: Network connected
> > DEBUG: monitor_ccache: Monitoring /tmp/krb5cc_1000_w9KVYa
> > DEBUG: ka_applet_command_line: Evaluating command line
> > DEBUG: credentials_expiring: Checking expiry <1800s
> > DEBUG: ka_nm_client_state_changed_cb: Network connected
> > DEBUG: credentials_expiring: Checking expiry <1800s
> 
> Thanks. I can reproduce it here now (you just have to clear the
> principal names from the preferences). The bug doesn't seem to be in
> krb5-auth-dialog itself since we get the prompt passed in from the
> Kerberos libs and it's already lacking the username. I'll investigate
> further.

The attached patch should fix this.
 -- Guido

diff --git a/src/ka-kerberos.c b/src/ka-kerberos.c
index fc6d63f..a17dee3 100644
--- a/src/ka-kerberos.c
+++ b/src/ka-kerberos.c
@@ -649,6 +649,10 @@ ka_parse_name (KaApplet *applet, krb5_context krbcontext,
         krb5_free_principal (krbcontext, *kprinc);
 
     g_object_get (applet, KA_PROP_NAME_PRINCIPAL, &principal, NULL);
+    if (principal[0] == '\0') {
+        g_free (principal);
+        principal = g_strdup (g_get_user_name());
+    }
     ret = krb5_parse_name (krbcontext, principal, kprinc);
 
     g_free (principal);