Re: Stable update proposal: sitesummary 0.0.33

[Daniel Hess <daniel@rio-grande.ping.de>]

On Sun, Dec 02, 2007 at 07:09:34PM +0100, Petter Reinholdtsen wrote:
> Daniel Hess reported on IRC that the peername fix gave him problems.
> Please hold off this update until we find a solution for it.

It does now work with 0.0.34 on etch with apache2.2.

Just one thing I've noticed, that is not very consistent:

In the "} elsif (my $sockaddr = getpeername($sockethandle)) {" part of
get_peerinfo $peeripstr is not set. Maybe something like

--- sitesummary-collector.cgi   (Revision 39599)
+++ sitesummary-collector.cgi   (Arbeitskopie)
@@ -154,6 +154,7 @@
         my $peerport;
         ($peerport, $peeripaddr) = sockaddr_in($sockaddr);
         $peername = gethostbyaddr($peeripaddr, AF_INET);
+       $peeripstr = inet_ntoa($peeripaddr);
     } else {
         # Running on the command line, use test host
         $peeripstr = "127.0.0.1";

would make sense?

Greetings

Daniel