Re: Please review my patch for sysklogd
Patrick Winnertz <patrick.winnertz@skolelinux.org> writes:
>> > diff -Nru /tmp/VrD1HUUixW/sysklogd-1.4.1/debian/rules /tmp/PdZaIpjxOf/sysklogd-1.4.1/debian/rules
>> > --- /tmp/VrD1HUUixW/sysklogd-1.4.1/debian/rules 2006-09-17 16:15:44.000000000 +0000
>> > +++ /tmp/PdZaIpjxOf/sysklogd-1.4.1/debian/rules 2006-09-17 16:15:44.000000000 +0000
>> > @@ -74,8 +74,8 @@
>> > chown -R root:root debian/tmp.sysklogd
>> > chmod -R g-ws debian/tmp.sysklogd
>> > $(installbin) -d debian/tmp.sysklogd/usr/share/doc/$(package)
>> > - $(installbin) debian/{preinst,postinst,postrm,prerm} debian/tmp.sysklogd/DEBIAN/
>> > - $(installdoc) debian/conffiles debian/tmp.sysklogd/DEBIAN/
>> > + $(installbin) debian/{preinst,postinst,postrm,prerm,config} debian/tmp.sysklogd/DEBIAN/
>> > + $(installdoc) debian/{conffiles,templates} debian/tmp.sysklogd/DEBIAN/
>>
>> For patching propose this is OK but I would suggest to use
>> dh_installdebconf and the rest of debhelper script bug it's outside of
>> your patch scope. The general packaging refactoring would be another
>> bug report. Keep in mind that current rules, used by the package, has
>> bashism and would break with dash and others shells.
>
> As I wrote above the maintainer doesn't want to use dh_* scripts :S
> I also dislike this way to package a deb.
> (But I doesn't want to fully replace the rules file, with a cdbs or
> debhelper one.
Yes. I see it.
>> [...]
>> > diff -Nru /tmp/VrD1HUUixW/sysklogd-1.4.1/debian/templates /tmp/PdZaIpjxOf/sysklogd-1.4.1/debian/templates
>> > --- /tmp/VrD1HUUixW/sysklogd-1.4.1/debian/templates 1970-01-01 00:00:00.000000000 +0000
>> > +++ /tmp/PdZaIpjxOf/sysklogd-1.4.1/debian/templates 2006-09-17 16:15:44.000000000 +0000
>> > @@ -0,0 +1,8 @@
>> > +Template: sysklogd/sysklogd-default-options
>> > +Type: string
>> > +Description: Enter the options you want sysklogd to use
>> > + Enter only the options like "-r" or "-m 0" without anything else before
>> > + or behind.
>> > +Description-de.UTF-8: Geben Sie die Optionen an, die sysklogd benutzen soll
>> > + Geben Sie lediglich die Optionen an, ohne zum Beispiel den Programmnamen davor
>> > + oder dahinter. Ähnlich wie dieses Beispiel: -r
>>
>> Use po-debconf for translation, please. Add it also in depends line
>> ;-)
>>
>> Hopefully you'll appreciate the commends but, as I said, this are my
>> personal POV and you might disagree.
>
> In my own packages I use po-debconf and cdbs | debhelper so I fully
> aggree with you. :)
> We should talk to the maintainer if he doesn't want to rewrite his rules
> file. (But as far as I can see, the maintainer doesn't want to have any
> build-depends).
>
> I will keep this way of packaging this package and rewrite the parts of
> the patch which are easy to change. (If I have enough time I will
> rewrite the whole rules file)
Well but po-debconf is basically a need. Otherwise you'll make the
translation harder.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
you the whole house."
Reply to: