Re: xournal FTBFS: wrongly declared R³
Guillem Jover:
> Hi!
>
> On Sat, 2020-10-24 at 11:54:54 +0200, Niels Thykier wrote:
>> Rather, I suspect the issue is that Rules-Requires-Root is set to "No"
>> rather than "no". AFAICT, only "no" has been defined and it is
>> interpreted case sensitively.
>
> Right, and even though this is described in the deb822(5) man page, it
> is not explicitly spelled out in the various specific file format man
> pages, so I've clarified that there. Also added more clear references
> to deb822(5) in the relevant man pages. Patches attached.
>
>> @Guillem/Dpkg Maintainers: Should we provide stricter validation for
>> this to stop this at dpkg-source build time ?
>
> Yeah, I think that make sense, as dpkg-buildpackage is already
> erroring out on unknown values for «dpkg/» namespaced keywords. So I
> prepared the attached patch to do this too.
>
> Thanks,
> Guillem
>
Thanks.
My pedantic nit would be to have dpkg-buildpackage be explicit in what
it expects if it already knows the right answer (which it does in this
case). E.g.
"R³ field keyword No is uppercase. Please use no instead"
Saves people a round-trip through the manual if they are unsure about
how to fix the error.
We should probably also add a special-case check for "yes" which I have
seen in the wild.
~Niels
Reply to: