[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Idea: sbuild/pbuilder "--dgit" option

* Mattia Rizzolo <mattia@debian.org> [161229 18:56]:
> On Thu, Dec 15, 2016 at 08:25:53PM +0000, Ian Jackson wrote:
> > This is because the default ignore rules (in dpkg-source) ignore
> > .gitignore, but dgit needs the source package to contain (any changes
> > to) .gitignore.  So dgit arranges that (if you use dgit to do the
> > build-for-upload) dpkg-source gets passed -i\.git/ -I.git.
> Oh, I've never realized that...
> > What would you think (particularly, sbuild and pbuilder folks) about a
> > supporting a --dgit option ?  The effect would be to pass -i\.git/
> > -I.git to dpkg-source.  (Possibly there might be other effects which
> > would be desirable, but this is the only essential one for those two
> > tools I think.)
> In general, I'm open to that for pbuilder (as I also expressed
> elsewhere), as long as it's not going to be documented in the "user
> manpage" and we manage changes to that interfaces only between us (i.e.,
> I don't want anybody else to start relying on the behavior of that
> flag).
> > I'm mailing you both at once, with a big CC list, because ISTM that a
> > conventional option name would be better than having each tool do its
> > own thing.
> Much appreciated, thank you.
> > Anyway, thanks to everyone for your opinions, whatever they may be.
> Here is pbuilder's maintainer view on this dpkg-source "problem":
> pbuilder never calls `dpkg-source -b` itself.  The only `dpkg-source`
> invocation I found by grepping the source is
>     dpkg-source -x $(basename "$PACKAGENAME")
> so, not affected by that.
> For pbuilder the only thing you can do is to pass
>     --debbuildopts --source-option=-i.git/ --debbuildopts --source-option=-I.git
> or
>     --debbuildopts "--source-option=-i.git/ --source-option=-I.git"
> whichever fits you better.

>From my point of view (and thus from a git-dpm workflow), ignoring
.gitignore as dpkg-source does by default is the only sane thing to do.
(I only wished it would by default also ignore debian/.git* and thus
include the debian/.git-dpm in the default ignore list).

I might be wrong, but having issues with .gitignore in the generated
source package is a dgit-only thing (and from what I understand from
DebConf2015) also not a technical but rather an ideological dgit thing.
Thus I guess naming such an option --dgit would only be natural.

	Bernhard R. Link
F8AC 04D5 0B9B 064B 3383  C3DA AFFC 96D1 151D FFDC

Reply to: