[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#703792: apt-get source add a space to -a option for dpkg-buildpackage



On Sun, 2013-03-24 at 08:16:36 +0800, Daniel Hartwig wrote:
> On 24 March 2013 03:07, YunQiang Su <wzssyqa@gmail.com> wrote:
> > Package: apt
> >
> > When cross build with apt-get source -amips -b ${any_package},
> > it will call dpkg-buildpackage like:
> >
> > dpkg-buildpakage -a mips -b -uc ${any_package}
> >
> > While dpkg-buildpackage don't allow a space between a and mips

> Dpkg, how about an idiom like the following for processing short options:
> 
> 
>      } elsif (/-a(.*)$/) {
> -        $targetarch = $1;
> +        $targetarch = $1 || shift @ARGV;
>      }
> 
> perhaps using a ‘maybeshiftopt’ that does shift if the next element of
> ARGV does not begin with "-", or return ""?

Yes, I've a patch locally that fixes all dpkg-dev scripts to accept
spaces after short options, I'll be pushing it to master in the coming
days.

In any case, you'll need the apt patch anyway for backwards compat.

Thanks,
Guillem


Reply to: