[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Dpkg::Version, Dpkg::Source::Package: move version-without-epoch outputting to the Version module

On Sat, 2013-02-09 at 15:03:31 +0100, Bernhard R. Link wrote:
> Instead of doing the magic of generating a version string without epoch
> and revision and a version string without epoch in
> Dpkg::Source::Package, extend Dpkg::Version's as_string function to
> support generating that string.

I like the idea, but I'd prefer the function to take a bitwise single
flag argument instead, with proper constants. APIs with several
booleans as arguments are confusing and not easy to read, as it's
not clear what the values are doing, or if they are booleans at all.
I'll merge this for 1.17.x once the above is done.


Reply to: