[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Dpkg::Version, Dpkg::Source::Package: move version-without-epoch outputting to the Version module


On Sat, 09 Feb 2013, Bernhard R. Link wrote:
> Instead of doing the magic of generating a version string without epoch
> and revision and a version string without epoch in
> Dpkg::Source::Package, extend Dpkg::Version's as_string function to
> support generating that string.

Ok, why not.

> -=item "$v", $v->as_string()
> +=item "$v", $v->as_string(), $v->as_string($no_epoch), $v->as_string($no_epoch, $no_revision)

But this makes for unreadable code. I'd prefer something like this:
$v->as_string(without_epoch => 1, without_revision => 1);

Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/

Reply to: