[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Next upload 2012-06-26 (dpkg 1.16.5)

On Sat, 2012-07-28 at 11:59:07 +0200, Neil McGovern wrote:
> On Mon, Jul 23, 2012 at 07:18:29PM +0200, Guillem Jover wrote:
> > On Mon, 2012-07-23 at 17:51:56 +0100, Neil McGovern wrote:
> > > Nope, 1.16.5. I'd like to see that to get a view as to why 1.16.5 was
> > > broken. Once we've managed to have a look at that, it may give a clue as
> > > to if it's worth reviewing the giant-diff-from-doom.
> > 
> > Thanks, attached the filtered diff (with additional junk left by
> > filterdiff, but left the changelog) from git:
> Right, the delta diff was small enough that I actually put in the time
> to look at the full diff. This took a number of hours, but anyway:

Well then, thanks for taking the time.

> Some questions:
> dpkg-1.16.8/dpkg-deb/main.c
>   -"  -h|--help                        Show this help message.\n"
>   -"  --version                        Show the version.\n"
>   +"  -?, --help                       Show this help message.\n"
>   +"      --version                    Show the version.\n"
> Why are you removing -h?

Using -h (or -H) on a program that you don't know its command-line
options could produce surprising effects, as such the only safe option
that can be used blindly is really --help, which is unambiguous (or -?
now). Keeping -h does not seem useful after those, so I removed them.
It also allows for the _possibility_ of considering reusing -h for
other uses in a pretty distant future, once there's no known dpkg
versions with the old semantics in the wild (JFTR there's still at
least dpkg 1.10.21 used on Fink, released in 2004-04).

Jonathan has already replied to the other inquiries.


Reply to: