[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Insufficient check on pkg-config



Hi,

Jonathan Nieder <jrnieder@gmail.com> (20/04/2011):
> Maybe something along these lines?

looks very nice, thanks.

> -- >8 --
> Subject: build: Catch attempts to autoreconf without pkg-config installed
> 
> The PKG_PROG_PKG_CONFIG macro contains some m4_pattern_forbid rules to
> catch unexpanded pkg-config macros, but that doesn't help much if
> pkg-config is not installed at aclocal time.  So unexpanded macros
> can escape into the configure script, producing errors at configure
> time.  Add our own rules to give the user a hint about where to start
> towards building dpkg:
> 
>  $ autoreconf -is
>  configure.ac:119: error: missing some pkg-config macros
>        If this token and others are legitimate, please use m4_pattern_allow.
>        See the Autoconf documentation.
>  autoreconf: /usr/bin/autoconf failed with exit status: 1
> 
> While at it, catch unexpanded DPKG_ macros in the same way.

Checked with DPKG_FOO_DOES_NOT_EXIST, looks also right:
| configure.ac:47: error: possibly undefined macro: DPKG_FOO_DOES_NOT_EXIST
|       If this token and others are legitimate, please use m4_pattern_allow.
|       See the Autoconf documentation.

> Reported-by: Cyril Brulebois <kibi@debian.org>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

Tested-by: Cyril Brulebois <kibi@debian.org>

KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: