[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Reimplement dpkg-divert in C



Mikhail Gusarov <dottedmag@dottedmag.net> writes:

> Twas brillig at 02:05:47 17.10.2009 UTC+02 when guillem@debian.org did gyre and gimble:
>
>  >> +                varbufaddstr(ret, "any ");
>  >> +
>  >> +        varbufaddstr(ret, "diversion of ");
>  >> +        varbufaddstr(ret, file);
>  >> +
>  >> +        if (divertto) {
>  >> +                varbufaddstr(ret, " to ");
>  >> +                varbufaddstr(ret, divertto);
>  >> +        }
>  >> +
>  >> +        if (package && strcmp(package, ":") != 0) {
>  >> +                varbufaddstr(ret, " by ");
>  >> +                varbufaddstr(ret, package);
>  >> +        }
>
>  GJ> Hmm, this makes translators work pretty hard. Also carried over from
>  GJ> the perl code, but as this is getting rewritten let's get it right.
>
> Is --list supposed to be only human-readable? Then we can change output
> format a bit to make it more localizable (12 similar strings like "local
> diversion of %s to %s by %s", "diversion of %s", "any diversion of %s by
> %s"... are localizable, but insane).

I think some maintainer scripts use --list. But I think they only care
wether there is a diversion. Maybe a --test for testing if something
is already diverted by a previous version and --list for users would
be better.

MfG
        Goswin


Reply to: