[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] Reimplement dpkg-divert in C



Twas brillig at 14:02:22 17.10.2009 UTC+02 when guillem@debian.org did gyre and gimble:

 >> I have tried to replicate dpkg-divert.pl behaviour exactly,
 >> including sorting of diversions file. If it is not necessary, I
 >> could make a testsuite a bit smarter instead.

 GJ> The behaviour should be preserved, yes, but the code layout does
 GJ> not need to, just what fits best with the rest of the code base. In
 GJ> this case duplicating part of the current infrastructure is not
 GJ> good.

Sure, I'll drop my reimplementation and will use existing code.

 >>  GJ> Why the FNM_NOESCAPE?
 >> To match Perl code - '\' is escaped there. Not that it really matters.
 GJ> The --list option is supposed to be taking a glob as argument,

Okay.

-- 
  http://fossarchy.blogspot.com/

Attachment: pgpiWhi8qvKTW.pgp
Description: PGP signature


Reply to: