[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Use FIBMAP to sort .list files before scanning

On Mon, 2009-10-05 at 11:56:25 +0000, Florian Weimer wrote:
> * Guillem Jover:
> > On kFreeBSD there's FIOGETLBA, but it seems to only be implemented for
> > the cd9660 file system, so not of much use. Also AFAIU from taking a
> > look at Linux, FIBMAP is being phased out by FIEMAP?
> FIBMAP is the correct system call here because FIEMAP does unnecessary
> work.

Yeah, that's also what I gathered from checking the kernel sources,
but then the comments on the code and some docs seem to point to it
being phased out, so dunno.

> It's root-only, though, and there are some concerns if it's
> actually safe to use (because no one could give a compelling reason
> why it was made root-only---FIEMAP isn't).

Yesterday I tracked down when the CAP_SYS_RAWIO check was added, on
2.2.11, but could not find any announcement with the description why
that change happened. I don't see why it would be unsafe, it just
returns an int, and the worst that could happen from dpkg side is that
we use a wrong order.


Reply to: