[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: should there be a dpkg-edit-patch

Raphael Hertzog <hertzog@debian.org> writes:

> On Tue, 28 Apr 2009, Goswin von Brederlow wrote:
>> But what if the package was unpacked without quilt? Or the user is not
>> familiar with quilt? Having to add files before editing takes getting
>> used to.
> Well, standardizing is interesting because one has to learn only one
> system and this system is quilt. So I don't want to replace quilt with
> dpkg tools. The user should have quilt installed and it will be used.
> Once the format is standard, I will add a Recommends: quilt to avoid
> this problem to some extent.
>> Wouldn't it be nice to have a dpkg-edit-patch command in dpkg-dev that
>> would work like dpatch-edit-patch and with or without quilt?
> No.

Then I think we at least need a way to make quilt work without
QUILT_PATCHES=debian/patches. Maybe there could be a .pc/patches file
that tells quilt where to find the debian patches and dpkg-source
would create that file (or rather quilt when it gets called by
dpkg-source the first time).

>> Additionaly I think it would be nice to be able to rename the
>> debian/patches/debian-changes-version file or merge it into a previous
>> patch. Maybe we could have
> Same answer, it's not really dpkg's businees IMO.

Running quilt rename does not alter the .dpkg-source-applied file and
dpkg-source currently insists on using that file even when using
quilt. Any objection to making dpkg-source not create that file in
quilt mode?

>> Last how about annotating the debian/patches/debian-changes-version
>> patch when generating it adding infos from DEBFULLNAME, NAME, DEBEMAIL
>> and/or EMAIL just like dch does when generating the changelog? If none
>> of them are set the name/email from the last changelog entry could be
>> used.
> Yes, it's in my plans. But I would like us to standardize those
> meta-informations first so that I can put a useful template. That's why I
> reserved DEP #3 (Patch Tagging Guidelines).
> Cheers,
> -- 
> Raphaël Hertzog


Reply to: