[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Integrated dpkg-parsechangelog processing into Dpkg::Changelog::parse_changelog()

On Thu, Jan 17, 2008 at 11:41:04PM +0100, Raphael Hertzog wrote:
> > That is a behavioural change, right? Up to now, dpkg-genchanges
> > includes all the descriptions in source-only uploads. I'm not sure this is
> > a behaviour we need to keep, just making sure everyone is aware that we
> > do.
> Indeed. It also means that XC-* fields are not forwarded for source-only
> uploads (but IMO, XC-* should only have an effect in the source part of the
> control file in general, but that's another discussion).
> We already don't include descriptions (and XC fields) of packages that have no
> corresponding .deb file uploaded (even if they are valid packages that are
> simply not built on the architecture of this upload). So this seemed like the
> logical behaviour for a source only upload.
> It's highly unlikely that we break anything with this change but on the other
> hand, as a frequent reviewer of .changes files, I appreciate having
> descriptions... so I'm wondering if we shouldn't change the behaviour in the
> opposite direction (always include all descriptions of all binary packages even
> those which are not uploaded).
> Opinions?

I would support that.

Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/

Reply to: