[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Integrated dpkg-parsechangelog processing into Dpkg::Changelog::parse_changelog()

On Wed, Jan 16, 2008 at 02:11:38PM +0100, Raphael Hertzog wrote:
> +The parsing itself is done by an external program (either in
> +/usr/local/lib/dpkg/parsechangelog, /usr/lib/dpkg/parsechangelog
> +or in $opt{libdir}). That program is named according to the format
> +that it's able to parse. By default it's "debian" but it can be overriden
> +with $opt{changelogformat}. The program expects the content of the
> +changelog file on its standard input.

Two misleading points here:
1) $opt{libdir} is search first before the default directories, that
isn't clear from the sentence.
2) The changelog format can also be autodetected from the changelog

> +    # Fork and call the parser
> +    my $pid = open(P, "-|");

$pid can be undefined if the fork() failed. This should be checked.


Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/

Reply to: