Re: Review of controllib-removal branch requested
On Thu, 17 Jan 2008, Guillem Jover wrote:
> > What would you suggest then ? Shall I add $substvar->set("Format",
> > $changes_format) in dpkg-genchanges ?
> Sure, and also override the Format field if such substvar is present
> as documented in the man page.
> In this case I think the documentation is bogus. $varlistfile has
> never been initialized since that option was added (fb269aa4). And I
> don't think it makes sense to initalize it by default.
Reverted and fixed the documentation.
> > As you say, if it's not initialised, we might as well drop the substvars
> > support in dpkg-source.
> One can always explicitely enable substvar processing by passing that
> option, so it's not completely useless (another thing is if that
> feature is desirable at all, but if it's disabled by default it does
> not hurt having it).
Indeed. Thanks for the review!
Le best-seller français mis à jour pour Debian Etch :