[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#260568: Sigh... I just found some bashisms that I missed before...



Package: dpkg
Version: 1.10.23
Severity: minor
Tags: patch

First of all, thanks for fixing the XSI:isms I reported earlier.
However, I improved my scripts a bit, and found the bashism
{}-globbing in debian/rules and methods/disk.update (*{}).
The included patch fixes this.

Rationale:
Policy 10.4
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html

The POSIX-link requires some reading, since it only contains a list of
what kind of globing that _is_ allowed, not examples of globing that
isn't...


Regards: David Weinehall

diff -ur dpkg-1.10.23-old/debian/rules dpkg-1.10.23/debian/rules
--- dpkg-1.10.23-old/debian/rules	2004-07-19 21:56:44.000000000 +0300
+++ dpkg-1.10.23/debian/rules	2004-07-21 10:40:43.000000000 +0300
@@ -70,7 +70,7 @@
 	rm -f debian/dpkg.substvars debian/dpkg-static.substvars
 	rm -fr autom4te.cache
 	rm -fr $(BUILD-DIRS) $(TMP)
-	rm -f po/{cat-id-tbl.c,stamp-cat-id,*.gmo}
+	rm -f po/cat-id-tbl.c po/stamp-cat-id po/*.gmo
 	rm -f stamp-build stamp-binary
 
 build: stamp-build
diff -ur dpkg-1.10.23-old/methods/disk.update dpkg-1.10.23/methods/disk.update
--- dpkg-1.10.23-old/methods/disk.update	2004-07-19 21:56:52.000000000 +0300
+++ dpkg-1.10.23/methods/disk.update	2004-07-21 10:41:51.000000000 +0300
@@ -22,7 +22,7 @@
 
 xit=1
 trap '
-	rm -f packages-{main,ctb,nf,nus,lcl}
+	rm -f packages-main packages-ctb packages-nf packages-nus packages-lcl
 	if [ -n "$umount" ]
 	then
 		umount "$umount" >/dev/null 2>&1



Reply to: