Bug#187534: marked as done (dpkg: protect sed commands in Makefile.in from shell)
Your message dated Mon, 28 Apr 2003 10:43:35 -0400
with message-id <E19A9qx-0001MZ-00@auric.debian.org>
and subject line Bug#187534: fixed in dpkg 1.10.10
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 4 Apr 2003 06:29:32 +0000
>From schechtm@amun-ra.clearblack.net Fri Apr 04 00:29:32 2003
Return-path: <schechtm@amun-ra.clearblack.net>
Received: from zzz-209254133018.splitrock.net (amun-ra.clearblack.net) [209.254.133.18] (root)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 191Khf-0006WE-00; Fri, 04 Apr 2003 00:29:31 -0600
Received: from amun-ra.clearblack.net (schechtm@localhost [127.0.0.1])
by amun-ra.clearblack.net (8.12.6/8.12.6/Debian-7) with ESMTP id h346TT8n011156;
Fri, 4 Apr 2003 00:29:29 -0600
Received: (from schechtm@localhost)
by amun-ra.clearblack.net (8.12.6/8.12.6/Debian-7) id h346TTMr011154;
Fri, 4 Apr 2003 00:29:29 -0600
Date: Fri, 4 Apr 2003 00:29:29 -0600
From: Matt Schechtman <debian-bugs@clearblack.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: dpkg: protect sed commands in Makefile.in from shell
Message-ID: <[🔎] 20030404062929.GA11143@clearblack.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="VbJkn9YxBvnuCH5J"
Content-Disposition: inline
X-Reportbug-Version: 1.50
User-Agent: Mutt/1.5.3i
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-2.8 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01,
USER_AGENT,USER_AGENT_MUTT
version=2.44
X-Spam-Level:
--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: dpkg
Version: 1.10.9
Severity: normal
Tags: patch
There is a sed command that uses characters that have meaning to the
shell in Makefile.in.
$(MAKE) $(MFLAGS) -C `echo $@ | sed s/[^-]*-//` `echo $@ | sed s/-.*//`
I was playing around with making dpkg work on some things other than
Linux and ran into this. The fix is simple - surround the sed commands
with '', which is a good idea anyway. I've attached a diff that fixes
this problem.
The symptom is the following output from sed on affected systems:
sed: command garbled: s/[
/bin/sh: -]*-//: not found
-- System Information
Debian Release: testing/unstable
Architecture: powerpc
Kernel: Linux amun-ra 2.4.19-xfs #13 Sat Oct 26 14:33:36 CDT 2002 ppc
Locale: LANG=C, LC_CTYPE=C
Versions of packages dpkg depends on:
ii dselect 1.10.9 a user tool to manage Debian packa
ii libc6 2.3.1-16 GNU C Library: Shared libraries an
--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="dpkg-Makefile.in.diff"
Index: Makefile.in
===================================================================
RCS file: /cvs/dpkg/dpkg/Makefile.in,v
retrieving revision 1.15
diff -u -r1.15 Makefile.in
--- Makefile.in 30 Aug 2002 00:36:44 -0000 1.15
+++ Makefile.in 4 Apr 2003 06:07:37 -0000
@@ -34,7 +34,7 @@
$(MAKE) $(MFLAGS) $(patsubst %,$*-%,$(SUBDIRS))
$(foreach target,all install clean distclean,$(patsubst %,$(target)-%,$(SUBDIRS))):
- $(MAKE) $(MFLAGS) -C `echo $@ | sed s/[^-]*-//` `echo $@ | sed s/-.*//`
+ $(MAKE) $(MFLAGS) -C `echo $@ | sed 's/[^-]*-//'` `echo $@ | sed 's/-.*//'`
.PHONY: all install clean distclean
.PHONY: all-recursive install-recursive clean-recursive distclean-recursive
--VbJkn9YxBvnuCH5J--
---------------------------------------
Received: (at 187534-close) by bugs.debian.org; 28 Apr 2003 14:53:03 +0000
>From troup@auric.debian.org Mon Apr 28 09:53:03 2003
Return-path: <troup@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 19AA07-0008QX-00; Mon, 28 Apr 2003 09:53:03 -0500
Received: from troup by auric.debian.org with local (Exim 3.35 1 (Debian))
id 19A9qx-0001MZ-00; Mon, 28 Apr 2003 10:43:35 -0400
From: Adam Heath <doogie@debian.org>
To: 187534-close@bugs.debian.org
X-Katie: lisa $Revision: 1.23 $
Subject: Bug#187534: fixed in dpkg 1.10.10
Message-Id: <E19A9qx-0001MZ-00@auric.debian.org>
Sender: James Troup <troup@auric.debian.org>
Date: Mon, 28 Apr 2003 10:43:35 -0400
Delivered-To: 187534-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive:
dpkg-dev_1.10.10_all.deb
to pool/main/d/dpkg/dpkg-dev_1.10.10_all.deb
dpkg-doc_1.10.10_all.deb
to pool/main/d/dpkg/dpkg-doc_1.10.10_all.deb
dpkg_1.10.10.dsc
to pool/main/d/dpkg/dpkg_1.10.10.dsc
dpkg_1.10.10.tar.gz
to pool/main/d/dpkg/dpkg_1.10.10.tar.gz
dpkg_1.10.10_i386.deb
to pool/main/d/dpkg/dpkg_1.10.10_i386.deb
dselect_1.10.10_i386.deb
to pool/main/d/dpkg/dselect_1.10.10_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 187534@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Heath <doogie@debian.org> (supplier of updated dpkg package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 26 Apr 2003 15:10:24 -0500
Source: dpkg
Binary: dpkg-doc dpkg dselect dpkg-dev dpkg-static
Architecture: source i386 all
Version: 1.10.10
Distribution: unstable
Urgency: low
Maintainer: Dpkg Development <debian-dpkg@lists.debian.org>
Changed-By: Adam Heath <doogie@debian.org>
Description:
dpkg - Package maintenance system for Debian
dpkg-dev - Package building tools for Debian
dpkg-doc - Dpkg Internals Documentation
dselect - a user tool to manage Debian packages
Closes: 170698 179656 179658 179659 179661 184239 187509 187534
Changes:
dpkg (1.10.10) unstable; urgency=low
.
* Update archtable for hurd. Closes: #187509.
* Make the dpkg-iasearch conflicts versioned. Closes: #170698.
* Surround sed call with '' in Makefile.in. Closes: #187534.
* Strip trailing / from the file args in dpkg-statoverride. Closes:
#184239.
* Modified to use autotools-dev. Closes: #179656.
* Add netbsd support. Closes: #179658, #179659.
* Support hypenated values in dpkg-architeture. Closes: #179661
* No longer managed the /usr/doc symlinks.
Files:
5be7b5f34f5c46eee78e8950477ed532 733 base required dpkg_1.10.10.dsc
e5cdb9e0f4de30fa9d5a8a0f97d23b0f 1547158 base required dpkg_1.10.10.tar.gz
ee24db271e96179da0e2c41eb25b0633 1140278 base required dpkg_1.10.10_i386.deb
b72f5511d6a5a5aed2eb3c5a71993ab6 92644 base required dselect_1.10.10_i386.deb
beacb09e4748bf16a6eefdf010c0e5a5 1129707 byhand - dpkg-1.10.10_i386.nondebbin.tar.gz
2fc3b8cbfbfab59eb3ba4ae6aea51e43 1594596 byhand - dpkg-1.10.10_i386-static.nondebbin.tar.gz
948c0acb3bb02c5cc6294502d4f96e54 111578 utils standard dpkg-dev_1.10.10_all.deb
83dddfc3a9e3daaaecaf4769d2033fbd 10618 doc optional dpkg-doc_1.10.10_all.deb
e5cdb9e0f4de30fa9d5a8a0f97d23b0f 1547158 byhand - dpkg-1.10.10.tar.gz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+qusZiix9wovUpIkRAkKkAJsGpyUSb6dXG26gpNXDhT+dMDXKoACfRGUK
ljdd7HJYE/JSiPi3sEeQRDw=
=NMrR
-----END PGP SIGNATURE-----
Reply to: