Bug#198218: dpkg: lib/parse.c: inverted sense of a EOF_mmap() test

[Andrew Suffield <asuffield@debian.org>]

Package: dpkg
Severity: important

<asuffield> doogie: I'm fairly sure there should be a ! before EOF_mmap(...
<doogie>       while (EOF_mmap(dataptr, endptr) && c != '\n' && isspace(c)) c= getc_mmap(dataptr);
<doogie>       if (EOF_mmap(dataptr, endptr))
<doogie> that might need to be !
<asuffield> that's the one
<asuffield> the first of those usually does nothing, but might segfault in corner cases (not sure about that)
<doogie> asuffield: file a bug about that for me, make it important

-- 
  .''`.  ** Debian GNU/Linux ** | Andrew Suffield
 : :' :  http://www.debian.org/ | Dept. of Computing,
 `. `'                          | Imperial College,
   `-             -><-          | London, UK

Attachment: pgp3Wuwrmk4a3.pgp
Description: PGP signature