[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: where should patches be sent?

Previously Robert Collins wrote:
> 1) Alter debian/rules to be .exe extension aware (only affects cygwin).
> 2) Alter all chmod root.root / install -o root -g root in debian/rules
> to 
> be $(ROOTUSER).$(ROOTGROUP)/ -o $(ROOTUSER) -g $(ROOTGROUP), with the 
> default values being root and root. Cygwin users override on the command
> line (perhaps in the future automagically) with their appropriate root
> user and group values. (i.e. Administrator and Administrators).

Souds reasonable

> 3) Alter all (found) instances of root checking in .c or scripts to use
> permission
> checks instead. (i.e. try and fail, rather than assume failure). (Only
> affects cygwin).

We should move those checks into a single place that routines can
call when needed.

> 4) A few timing calls in some perl scripts, to help address in-use file
> replacement races. This is both a partial fix, and not-really-needed as
> dpkg should not be installing stuff with cygwin - setup.exe is used for
> that. Still, if something is going to be done, do it right.

Don't bother, those scripts are being rewritten in python so working
on merging changes in the perl implementation might be a waste of

> In the future there will also be a file mode set of patches, to force
> binary or text mode reading and writing on appropriate files. That's not
> even started yet.

Is that really needed?


 /wichert@wiggy.net         This space intentionally left occupied \
| wichert@deephackmode.org            http://www.liacs.nl/~wichert/ |
| 1024D/2FA3BC2D 576E 100B 518D 2F16 36B0  2805 3CB8 9250 2FA3 BC2D |

To UNSUBSCRIBE, email to debian-dpkg-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Reply to: