Re: Bug#822083: refcard: The refcard layout is screwed up for RTL languages
Hi,
Holger Wansing <linux@wansing-online.de> wrote:
> Holger Wansing <linux@wansing-online.de> wrote:
> > Omer Zak <w1@zak.co.il> wrote:
> > > 1. Explanations of the changes:
> > >
> > > debian/rules
> > > LC_ALL=en_US.utf8
> > > Fixes the behavior of 'grep' when it deals with text with non-Latin
> > > characters.
> > > Without this change, 'grep' outputs 'Binary file _____ matches', causing
> > > further operations in the build to fail.
[...]
> > I'm lacking the skills to value this patch, so could please someone comment
> > on it?
>
> Are there any objections against me committing that parts of the patch,
> which are related to Hebrew?
> Since I have no proofreader for Arabic until now, I feel somewhat uncomfortable
> with applying changes to Arabic ATM.
>
>
> Holger
I should have mentioned explicitly, that Omer proposed to change the global
build variables in debian/rules, so that might affect all languages!
Are there any known side effects or objections on adding
LC_ALL=en_US.utf8
to the used environment variables for building refcard?
I could not see any difference while testing the proposed chagings though.
Holger
--
============================================================
Created with Sylpheed 3.5.0 under
D E B I A N L I N U X 8 . 0 " J E S S I E " .
Registered Linux User #311290 - https://linuxcounter.net/
============================================================
Reply to: