[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#822083: refcard: The refcard layout is screwed up for RTL languages



Hi,

Holger Wansing <linux@wansing-online.de> wrote:
> Omer Zak <w1@zak.co.il> wrote:
> > Source: refcard
> > Severity: minor
> > Tags: upstream patch l10n
> > 
> > 
> > The Hebrew and Arabic layouts were fixed by the enclosed patch which is based
> > upon svn repository version 11118.
> > 
> > 1. Explanations of the changes:
> > 
> > debian/rules
> >     LC_ALL=en_US.utf8
> >     Fixes the behavior of 'grep' when it deals with text with non-Latin
> >     characters.
> >     Without this change, 'grep' outputs 'Binary file _____ matches', causing
> >     further operations in the build to fail.
> 
> Are there any possible side effects in setting "LC_ALL=en_US.utf8" ?
> 
> 
> > fo.xsl
> >     The layout for RTL languages is fine without writing-mode='rl-tb'.
> > 
> > he.po
> >     All Hebrew translations were enclosed in RLE/PDF to force RTL as their
> >     major direction.
> >     Further fixes were made after proofreading.
> > 
> > ar.po
> >     All Arabic translations were enclosed in RLE/PDF to force RTL as their
> >     major direction.
> >     The file needs to be proofread and more LRE/RLE/PDF characters added at
> >     various strings.
> > 
> > 2. Two optional files:
> > 
> > po_processor.py
> >     One-shot script for processing he.po,ar.po and enclosing RTL strings
> >     in RLE/PDF because this directionality is no longer proviced by the
> >     templates subjected to fo.xsl.
> > 
> >     The script was written to be idempotent, and you may want to consider
> >     adding it to the build flow, allowing future translators not to manually
> >     enclose new strings in RLE/PDF.
> > 
> >     This script requires that python3 and python3-polib be added to the
> >     package's build dependencies.
> > 
> > run_po_processor.sh
> >     Runs the po_processor.py script on ar.po, fa.po (once it exists) and
> >     he.po.
> 
> Maybe some comments on how to use that scripts would be useful?
> (how to execute, in which situations, ...)
> 
> 
> 
> I'm lacking the skills to value this patch, so could please someone comment
> on it? 

Are there any objections against me committing that parts of the patch,
which are related to Hebrew?
Since I have no proofreader for Arabic until now, I feel somewhat uncomfortable
with applying changes to Arabic ATM.


Holger

-- 
============================================================
Created with Sylpheed 3.5.0 under
	D E B I A N   L I N U X   8 . 0   " J E S S I E " .

Registered Linux User #311290 - https://linuxcounter.net/
============================================================


Reply to: