On Sun, Aug 17, 2025 at 10:33:16PM -0400, Theodore Ts'o wrote: > On Sun, Aug 17, 2025 at 02:44:06PM -0700, Otto Kekäläinen wrote: > > In the web interface you can suggest changes that automatically become > > patches on the branch, which the original submitter can easily clean > > up / integrate next time they rebase/refresh the MR. > > My point was that it takes a lot more effort, and time, to tell the > submitter what to change, and then (a) wait for them to make the > change, and (b) hope they make the change correctly. If they don't > then you have to repeat, possily multiple times. > > You could just make the change yourself, and then do a "git commit > --amend", but then the MR won't get closed automatically, becaue the > forge won't recognize the modified commit. And if you do a "git > commit" instead ofa "git commit --amend", then you break bisectibility > of the git tree. > > Yes, you could then close the commit manually, but now it's more work > than the e-mail based workflow. Just to make things clear: I believe that Otto's point in his second paragraph (the one you snipped) was that you can make the changes in your local Git checkout and then you can force-push to *the submitter's* branch in the forge, thus making *your* changes what is being proposed in that merge request. That would then let you accept the MR and have your own changes merged. I admit I wasn't aware of the fact that one can push a branch that lives in a "personal" fork of the Git repository on the forge; thanks, Otto. Still, I agree that this is more work, and this is partly what I meant when I first said that this is not always easy or convenient. G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com PGP key: https://www.ringlet.net/roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature